devinxi patch #228
Open
devinxi patch #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit: |
Brendonovich
approved these changes
Sep 2, 2025
34 tasks
atk
reviewed
Nov 3, 2025
| ...config.resolve.conditions, | ||
| ]; | ||
| config.resolve.externalConditions ??= []; | ||
| config.resolve.externalConditions.push("solid"); |
Contributor
There was a problem hiding this comment.
You can push multiple things at the same time:
config.resolve.externalConditions.push("solid", "node");
atilafassina
requested changes
Nov 14, 2025
Member
There was a problem hiding this comment.
Yo. I think it's safe to merge this.
Can you address Alex's point? Imho, it's a good change to make
We just need to
- solve conflicts to
main - Add a
patchchangeset so the release is triggered - Extend the explanation (this is not limited to Start) for the changeset and, add the same explanation in the PR description (just for historical reason)
Happy to ship it then 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for solid-start devinxi branch